Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set test-fs-cp as flaky #56799

Merged
merged 1 commit into from
Jan 30, 2025
Merged

test: set test-fs-cp as flaky #56799

merged 1 commit into from
Jan 30, 2025
+2 −0

Conversation

StefanStojanovic
Copy link
Contributor

Refs: #56794

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 28, 2025
@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64795/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (50d405a) to head (39f32bb).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56799   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files         663      663           
  Lines      191974   191974           
  Branches    36926    36920    -6     
=======================================
+ Hits       171286   171295    +9     
+ Misses      13561    13555    -6     
+ Partials     7127     7124    -3

see 34 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64800/ 💛

@juanarbol juanarbol added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 29, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2025
@nodejs-github-bot nodejs-github-bot merged commit 304bb9c into nodejs:main Jan 30, 2025
74 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 304bb9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@StefanStojanovic @nodejs-github-bot @jasnell @lpinca @targos @richardlau @aduh95 @juanarbol